Project

General

Profile

Actions

Feature #544

closed

Pass a reference to a DcmDataset to DcmFileFormat without creating a copy

Added by Jörg Riesmeier about 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Library
Target version:
-
Start date:
2013-08-23
Due date:
% Done:

0%

Estimated time:
Module:
dcmdata, (dcmnet)
Operating System:
Compiler:

Description

Currently, the DcmFileFormat constructor accepting a DcmDataset* always creates a copy. This is ok in many cases but a little inefficient if the DcmFileFormat instance is only created to save the dataset to a file (with meta header). See e.g. this commit.

Attached is a patch, that allows for specifying whether to create a copy or just reference the given dataset.

This new feature would be especially helpful for the SCU/SCP classes in "dcmnet", e.g. when storing a received DICOM dataset. However, deleting the passed DcmDataset during DcmFileFormat destruction might not always be desired since the dataset is still in use ...


Files

dcfilefo.patch (2.08 KB) dcfilefo.patch Patch for DcmFileformat Jörg Riesmeier, 2013-08-23 14:10
Actions #1

Updated by Jörg Riesmeier about 12 years ago

  • Priority changed from Normal to Low

We now have another solution for this use case (in DcmStorageSCP / dcmrecv): http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=b1c6dbefd1750ddec82dde5a1cd11171229eca44

Actions #2

Updated by Michael Onken almost 12 years ago

  • Status changed from New to Closed

Added functionality to one of the DcmFileFormat constructors.

Actions

Also available in: Atom PDF