Bug #880: storescp does not populate all placeholders for the --exec-on-eostudy when receiving the first batch of images - DCMTK - OFFIS DCMTK and DICOM Projects

Actions

Copy link

Bug #880

closed

storescp does not populate all placeholders for the --exec-on-eostudy when receiving the first batch of images

Added by Marco Eichelberg over 6 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Application

Target version:

3.6.6

Start date:

2019-04-25

Due date:

% Done:

100%

Estimated time:

2:00 h

Module:

dcmnet

Operating System:

Compiler:

Description

Apparently, the "placeholders" #a, #c and #r (which should contain the calling/called AEtitle and the calling presentation address) are not properly populated during the first execution of the --exec-on-eostudy command line, but they are populated for all further calls. According to the bug report, this behavior has been present with prior releases as well.

Reported 2019-04-16 by Andreas Keizers <an-kei@web.de>.

History
Notes
Property changes

Actions

Copy link

Updated by Jan Schlamelcher almost 6 years ago

Target version changed from 3.6.5 to 3.6.6

Actions

Copy link

Updated by Michael Onken over 5 years ago

I could not reproduce this for now. On Linux, I used:

storescp 1234 -v -xcs 'echo #a on #r to #c' --sort-on-study-uid s

I send two images (different studies) using dcmsend and I get:

I: Association Received
I: Association Acknowledged (Max Send PDV: 16372)
I: Received Store Request (MsgID 1, SC)
RECV: .................................................................................................................................
W: subdirectory for study already exists: ./s_1.3.12.2.1107.5.4.1.12.199705071523410083804
I: storing DICOM file: ./s_1.3.12.2.1107.5.4.1.12.199705071523410083804/SC.1.3.12.2.1107.5.4.1.12.199705071525320942958
W: DICOM file already exists, overwriting: ./s_1.3.12.2.1107.5.4.1.12.199705071523410083804/SC.1.3.12.2.1107.5.4.1.12.199705071525320942958
I: Association Release
I: Association Received
I: Association Acknowledged (Max Send PDV: 16372)
I: Received Store Request (MsgID 1, SC)
RECV: .................................................................................................................................
W: subdirectory for study already exists: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256
I: storing DICOM file: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256/SC.1.3.12.2.1107.5.4.1.12.199705071537340316837
W: DICOM file already exists, overwriting: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256/SC.1.3.12.2.1107.5.4.1.12.199705071537340316837
I: Association Release
DCMSEND on localhost to ANY-SCP

Which looks like the expected behaviour. If end of study is detected by timeout I get a comparable result. E.g. by running

storescp 1234 -v -xcs 'echo #a on #r to #c' --sort-on-study-uid s

and sending a single image one gets:

I: Association Received
I: Association Acknowledged (Max Send PDV: 16372)
I: Received Store Request (MsgID 1, SC)
RECV: .................................................................................................................................
W: subdirectory for study already exists: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256
I: storing DICOM file: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256/SC.1.3.12.2.1107.5.4.1.12.199705071537340316837
W: DICOM file already exists, overwriting: ./s_1.3.12.2.1107.5.4.1.12.199705071537340314256/SC.1.3.12.2.1107.5.4.1.12.199705071537340316837
I: Association Release
DCMSEND on localhost to ANY-SCP

Actions

Copy link

Updated by Michael Onken over 5 years ago

Target version deleted (~~3.6.6~~)

Actions

Copy link

Updated by Michael Onken over 5 years ago

Status changed from New to Closed

Closed since not replicable by DCMTK team and no other feedback from bug reporter.

Actions

Copy link

Updated by Marco Eichelberg almost 5 years ago

Status changed from Closed to Reopened

Bug can be reproduced by the following steps:

Prepare a file set containing images from two different studies (here: /path/to/test/)
mkdir /path/to/storescp/spool/
storescp -aet MYSCP -od /path/to/storescp/spool/ -pm -sp -dhl -tos 3 -xcs "echo #p #a #c #r" 11112
dcmsend -v -aec MYSCP -aet MYSCU -nh +sd +r 0.0.0.0 11112 /path/to/test/

Output looks like this:
/path/to/storescp/spool/PATIENTNAME_20201103_130021939
/path/to/storescp/spool/PATIENTNAME_20201103_130022775 MYSCU MYSCP 127.0.0.1

The reason is that in storescp.cc, function executeOnEndOfStudy(), the variables lastCallingAETitle, lastCalledAETitle, and lastCallingPresentationAddress are empty strings.

Actions

Copy link

Updated by Jörg Riesmeier almost 5 years ago

Category set to Application
Status changed from Reopened to Closed
Target version set to 3.6.6
% Done changed from 0 to 100
Estimated time set to 2:00 h

Closed with commit f8d0536.

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

DCMTK

Bug #880

storescp does not populate all placeholders for the --exec-on-eostudy when receiving the first batch of images

Updated by Jan Schlamelcher almost 6 years ago

Updated by Michael Onken over 5 years ago

Updated by Michael Onken over 5 years ago

Updated by Michael Onken over 5 years ago

Updated by Marco Eichelberg almost 5 years ago

Updated by Jörg Riesmeier almost 5 years ago