Project

General

Profile

Actions
Copy link

Bug #816

closed

DcmVR::setVR() should check whether internal VR is acceptable

Added by Jörg Riesmeier over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jörg Riesmeier
Category:
Library
Target version:
-
Start date:
2018-03-09
Due date:
% Done:

100%

Estimated time:
Module:
dcmdata
Operating System:
Compiler:

Description

Commit 40c9085 fixes a heap overflow issue that is caused by an invalid dataset. This is done by making sure that internal VRs (such as "PixelData" and "OverlayData") are handled appropriately in DcmItem::newDicomElement().

However, this is just a workaround. It would probably make more sense to check for these internal VRs already in DcmVR::setVR(onst char*), which is also called by the corresponding constructor of this class. Special attention should be paid that required mappings from internal VR names to the associated enum (e.g. in dump2dcm?) still works.

Actions
Copy link

Also available in: Atom PDF