Project

General

Profile

Actions
Copy link

Patch #708

closed

DCMTKConfigVersion.cmake not present in install

Added by Waldir Pimenta over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Michael Onken
Category:
Configuration
Target version:
3.6.2
Start date:
2017-01-02
Due date:
% Done:

0%

Estimated time:
Module:
CMake
Operating System:
Compiler:

Description

When locally building DCMTK, both DCMTKConfig.cmake and DCMTKConfigVersion.cmake are generated in the build directory. However, when doing make install, only DCMTKConfig.cmake is copied to the install directory, which makes the use of the library in other CMake-based projects fail if a version is passed to find_package().

After some investigation, I found the issue to be a capitalization mistake: in CMake/GenerateCMakeExports.cmake the version file is stored in the DCMTK_CONFIG_VERSION variable, while CMakeLists.txt looks for it in ${dcmtk_config_version}.

The attached patch fixes this issue (tested locally, works without issues) and adjusts the comments in CMakeLists.txt accordingly.

Files

Download all files
0001-fix-CMake-definitions-to-properly-install-DCMTKConfi.patch (3.41 KB) 0001-fix-CMake-definitions-to-properly-install-DCMTKConfi.patch Waldir Pimenta, 2017-01-02 17:01
0001-fix-CMake-definitions-to-properly-install-DCMTKConfi.patch (4.27 KB) 0001-fix-CMake-definitions-to-properly-install-DCMTKConfi.patch Waldir Pimenta, 2017-01-02 17:35
Actions
Copy link

Also available in: Atom PDF