Project

General

Profile

Actions
Copy link

Patch #507

closed

Diverse Bugfixes von Per Inge Mathisen

Added by Marco Eichelberg over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Category:
Library
Target version:
3.6.2
Start date:
2013-03-05
Due date:
% Done:

90%

Estimated time:
Module:
Operating System:
Compiler:

Description

The attached patch fixes various issues found by running latest version
of cppcheck over dcmtk git master. Note that I have not tested these
changes, apart from running them through you unit tests

Concerning the last change - it is apparently a very bad idea to throw
an exception from a destructor, and cppcheck considers it an error.

More fixes after running static analysis on your software.

ofstringoffbyone.diff - fixes a few off-by-one errors in your fallback
implementation of std::string. After skimming through that code, I think
I would recommend that you retire it and rely on working std::string
implementations instead.

misc.diff - various places where pointers could be dereferenced while
NULL

Files

Download all files
cppcheckfixes.diff (4.88 KB) cppcheckfixes.diff Marco Eichelberg, 2013-03-05 09:42
misc.diff (1.8 KB) misc.diff Marco Eichelberg, 2013-03-05 09:42
ofstringoffbyone.diff (1.07 KB) ofstringoffbyone.diff Marco Eichelberg, 2013-03-05 09:42
Actions
Copy link

Also available in: Atom PDF