Project

General

Profile

Actions

Feature #451

closed

Use #define WIN32_LEAN_AND_MEAN when including <windows.h>

Added by Jörg Riesmeier almost 13 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jan Schlamelcher
Category:
Library
Target version:
Start date:
2012-09-21
Due date:
% Done:

100%

Estimated time:
Module:
all
Operating System:
Compiler:

Description

While fixing some typos in the new header file "ofnetdb.h", I discovered that "windows.h" is included in this header file. In order to increase the performance of the compilation process, it should be checked whether compilation still works when defining WIN32_LEAN_AND_MEAN (directly in front of this include statement).

This also applies to all other files in the DCMTK (public and private part) where "windows.h" is included in this manner. This is especially true for header files!

Actions #1

Updated by Jan Schlamelcher almost 13 years ago

  • % Done changed from 0 to 100

Fixed in 02c64634b7bd466f2b1bba48c48738699f294443

Actions #2

Updated by Jörg Riesmeier almost 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 100 to 80

Other modules are still waiting to be changed ...

Actions #3

Updated by Jan Schlamelcher over 8 years ago

  • Status changed from Resolved to Closed

Closed in commit #9f9d70dc5c93.

Actions #4

Updated by Jörg Riesmeier over 8 years ago

  • % Done changed from 80 to 100
Actions #5

Updated by Jan Schlamelcher over 8 years ago

Was closed in commits #9f9d70dc5c93 and #d84184e83111ed (the latter not mentioning it though).

Actions #6

Updated by Jörg Riesmeier over 8 years ago

  • Status changed from Closed to Reopened
  • % Done changed from 100 to 80

Recent commits (e.g. bfe495a, 16b0782 and 3332ea4) again include "windows.h" without defining WIN32_LEAN_AND_MEAN even though it would be possible (tested at some places). There is also an include in a header file! This should be changed.

Actions #7

Updated by Jan Schlamelcher over 8 years ago

  • Status changed from Reopened to Closed
  • % Done changed from 80 to 100

Closed by commit #55fb9b8cefdc2820b.

Actions

Also available in: Atom PDF