Feature #416
open
Vollständiges und vor allem funktionierendes "FindDCMTK.cmake" schreiben
0%
Description
Anforderungen:
- An dem "offiziellen" Muster für FindXXX.cmake-Dateien orientiert.
- Unterstützung zumindest für DCMTK 3.5.4, 3.5.5, 3.6.0 und 3.6.1.
- Berücksichtigung der besonderen Bedürfnisse von DCMTK und CTK.
Siehe auch diverse Postings dazu auf Mailing-Listen, im Forum usw.
Files
Updated by Jörg Riesmeier over 12 years ago
- Category set to Configuration
- Assignee changed from Michael Onken to Uli Schlachter
- Target version set to 3.6.2
Hier ist ein Vorschlag vom "Insight Software Consortium":
http://forum.dcmtk.org/viewtopic.php?f=3&t=3682
Den sollte man sich wohl mal genauer anschauen ...
Updated by Michael Onken over 12 years ago
- File 0001-COMP-Add-CMAKE-code-to-generate-comprehensive-DCMTKC.patch 0001-COMP-Add-CMAKE-code-to-generate-comprehensive-DCMTKC.patch added
Find patch from Kent Williams attached (Kitware, ITK).
Updated by Uli Schlachter over 12 years ago
- File cleaner-3rdparty.patch cleaner-3rdparty.patch added
I tried to figure out what Kent's patch actually does and thus started undoing the rewrite of CMake/3rdparty.cmake (why does he have to write everything lower-case? Why does he have to turn every instance of endif and else into "endif()" and "else()"? Just to make the patch more unreadable? Thanks...).
I gave up after a while. This patch does not just implement something like FindDCMTK.cmake, it rewrites all of our CMake files. Since this has nothing to do with the intention of the patch and the reason for this is not explained in the commit message, someone else can figure out this mess (or propose to Kent to split this up into several patches, each of which does ONE thing in logically consistent steps).
Updated by Uli Schlachter over 12 years ago
Oh and I just noticed this gem:
# Declare installation files
INSTALL(TARGETS ${LIBRARY}${DCMTK_LIBRARY_SUFFIX}
- COMPONENT lib
- RUNTIME DESTINATION ${DCMTK_INSTALL_BINDIR}
- LIBRARY DESTINATION ${DCMTK_INSTALL_LIBDIR}
- ARCHIVE DESTINATION ${DCMTK_INSTALL_LIBDIR})
+ EXPORT DCMTKLibraryDepends
+ RUNTIME DESTINATION ${INSTALL_BIN_DIR} COMPONENT bin
+ LIBRARY DESTINATION ${INSTALL_LIB_DIR}/lib COMPONENT shlib
+ ARCHIVE DESTINATION ${INSTALL_LIB_DIR}/lib COMPONENT lib)
ENDIF(NOT BUILD_SINGLE_SHARED_LIBRARY)
ENDMACRO(DCMTK_ADD_LIBRARY)
He moves libraries from the component "lib" into "bin" and he breaks DCMTK_INSTALL_BINDIR/_LIBDIR without explaining why. And all of this in a patch which is supposed to do something completely unrelated...
Updated by Jörg Riesmeier over 9 years ago
- Status changed from New to Feedback
- Assignee set to Michael Onken
Solved by the Kitware people (JC)?
Updated by Marco Eichelberg over 8 years ago
- Category deleted (
Configuration) - Target version changed from 3.6.2 to 3.6.3
Updated by Jan Schlamelcher over 7 years ago
- Target version changed from 3.6.3 to 3.6.6
Updated by Jörg Riesmeier over 7 years ago
- Category set to Configuration
Can't this issue be closed?