Project

General

Profile

Actions

Bug #705

closed

Class DRTModifiedAttributesSequence::Items has no members

Added by Jörg Riesmeier over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Library
Target version:
Start date:
2016-12-06
Due date:
% Done:

100%

Estimated time:
Module:
dcmrt
Operating System:
Compiler:

Description

Therefore, the read() method does nothing (useful) and "gcc -Wextra" reports the following warnings:

c++     -DHAVE_CONFIG_H -DUSE_NULL_SAFE_OFSTRING -DDCMTK_BUILD_IN_PROGRESS -DHAVE_STD_STRING -DHAVE_STL  -DNDEBUG  -c -I. -I. -I../include -I../../config/include -I../../ofstd/include -I../../oflog/include -I../../dcmdata/include -I../../dcmimgle/include   \
         -O -I/usr/include/libxml2 -D_REENTRANT -D_XOPEN_SOURCE_EXTENDED -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_POSIX_C_SOURCE=199506L -Wall -Wextra drtmas.cc
drtmas.cc:70:13: warning: unused parameter ‘item’ [-Wunused-parameter]
 OFCondition DRTModifiedAttributesSequence::Item::read(DcmItem &item)
             ^
drtmas.cc:83:13: warning: unused parameter ‘item’ [-Wunused-parameter]
 OFCondition DRTModifiedAttributesSequence::Item::write(DcmItem &item)
             ^

The reason is: The content of the Modified Attributes Sequence in the SOP Common Module is defined in a quite generic way as "Any Attribute from the main data set that was modified or removed." (see PS3.3 Table C.12-1).

Solution: Enhance the generator script accordingly (e.g. by introducing another "special case" for this and similar sequences).

Actions #1

Updated by Jörg Riesmeier over 8 years ago

  • % Done changed from 0 to 100

Fixed with commit d6d041b.

Actions #2

Updated by Jörg Riesmeier over 8 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF