Project

General

Profile

Actions

Bug #696

closed

Segmentation fault in dcmimgle when using LUTs >= 32bit

Added by Jan Schlamelcher almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
High
Category:
Library
Target version:
Start date:
2016-10-12
Due date:
% Done:

100%

Estimated time:
Module:
dcmimgle
Operating System:
32-bit
Compiler:

Description

Lines like const unsigned long ocnt = OFstatic_cast(unsigned long, inter->getAbsMaxRange()); in DiMonoOutputPixelTemplate (dcmtk/dcmimgle/dimoopxt.h) limit the number of LUT entries to what is representable by an unsigned long (Uint32 in most cases). These lines should be identified and changed to size_t instead.


Files

overflow_696.patch (10.4 KB) overflow_696.patch Patch suggested by original discoverer of the bug (John Stark) Jan Schlamelcher, 2016-10-18 10:12
Actions #1

Updated by Jörg Riesmeier almost 9 years ago

I don't think that changing the data type is a proper solution to this issue. An array with more than 4.2 billion entries is certainly not desirable - at least not for optimization purposes.

Actions #2

Updated by Jan Schlamelcher almost 9 years ago

Actions #3

Updated by Jörg Riesmeier almost 9 years ago

  • Status changed from New to Closed
  • Assignee changed from Thorben Hasenpusch to Jörg Riesmeier
  • % Done changed from 0 to 100
  • Operating System set to 32-bit

Fixed with commit a8cf5d1.

Actions

Also available in: Atom PDF