Feature #579
closed
Avoid too many boolean parameters in convertCharacterSet() methods
90%
Description
With this commit (http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=bfa3354b41f86111d7a9a383fae809bbf0754f17), a new boolean parameter "discardIllegal" has been introduced to the various convertCharacterSet() methods. It would probably be better to combine this "new" flag with the existing "transliterate" flag into a single integer parameter (of type "size_t"?). This makes sure that (in the future) additional flags can be introduced without a need to change the signature of the API method again. Also the order of parameters is currently a little confusing (too many booleans -- in which order?).
Maybe, this commit (http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=9fd4776a56b2435c45f0929cdb11e8f78a20d92f) should also be revisited by using an integer flag instead of two booleans. But that is certainly more a matter of taste...
The "target version" is set to "3.6.2" since API changes should happen before the the next release.
Updated by Jörg Riesmeier almost 9 years ago
- Status changed from New to Closed
- % Done changed from 0 to 90
Fixed by commit 7018b99.