Project

General

Profile

Actions

Feature #404

open

Update "oflog" to latest log4cplus release

Added by Jörg Riesmeier over 13 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Library
Target version:
-
Start date:
2012-04-26
Due date:
% Done:

60%

Estimated time:
Module:
oflog
Operating System:
Compiler:

Description

Bis zum nächsten DCMTK-Release sollte ein sorgfältiger Abgleich mit der aktuellen Version der log4cplus-Bibliothek stattfinden.


Files

oflog.patch (2.21 MB) oflog.patch Uli Schlachter, 2012-12-18 17:21
oflog2.patch (2.2 MB) oflog2.patch Uli Schlachter, 2013-01-08 12:19
Actions #1

Updated by Uli Schlachter almost 13 years ago

log4cplus 1.1.0 was released on 02.10.2012. Sounds like something we could use. :-)

Actions #2

Updated by Jörg Riesmeier almost 13 years ago

Here's a list of new features (from log4cplus's homepage):

AsyncAppender, Log4jUdpAppender, SysLogAppender with remote syslog UDP logging support enabled on Windows, Qt4DebugAppender, simple C interface for interoperability with C, inter–process file locking to file appenders to allow logging into a single log file from multiple processes, Mapped Diagnostic Context (MDC), alternative thread identification (%T) converter to pattern layout, function name converter (%M), wchar_t ↔ char conversion implementations based on standard C locale functions and based on iconv(), DeviceAppender to allow use of Boost.IOStream's Sink as appender, LOG4CPLUS_*_FMT() macros to allow printf-like formatted output where it is possible (requires variadic macros support).

Actions #3

Updated by Uli Schlachter almost 13 years ago

Since I am pretty sure that I won't be handling this on first checking (remind me to remind Jörg to do a snapshot before I break oflog), here is the list of new configure macros needed by log4cplus 1.1.0:

$ git diff config | grep '+#define'
+#define DCMTK_LOG4CPLUS_HAVE_ARPA_INET_H
+#define DCMTK_LOG4CPLUS_HAVE_NETINET_TCP_H
+#define DCMTK_LOG4CPLUS_HAVE_SYS_TIMEB_H
+#define DCMTK_LOG4CPLUS_HAVE_SYS_TIME_H
+#define DCMTK_LOG4CPLUS_HAVE_SYS_STAT_H
+#define DCMTK_LOG4CPLUS_HAVE_SYS_SYSCALL_H
+#define DCMTK_LOG4CPLUS_HAVE_SYS_FILE_H
+#define DCMTK_LOG4CPLUS_HAVE_TIME_H
+#define DCMTK_LOG4CPLUS_HAVE_FCNTL_H
+#define DCMTK_LOG4CPLUS_HAVE_STDARG_H
+#define DCMTK_LOG4CPLUS_HAVE_STDIO_H
+#define DCMTK_LOG4CPLUS_HAVE_STDLIB_H
+#define DCMTK_LOG4CPLUS_HAVE_ERRNO_H
+#define DCMTK_LOG4CPLUS_HAVE_WCHAR_H
+#define DCMTK_LOG4CPLUS_HAVE_ICONV_H
+#define DCMTK_LOG4CPLUS_HAVE_LIMITS_H
+#define DCMTK_LOG4CPLUS_HAVE_GETHOSTBYNAME_R
+#define DCMTK_LOG4CPLUS_HAVE_CLOCK_GETTIME
+#define DCMTK_LOG4CPLUS_HAVE_NANOSLEEP
+#define DCMTK_LOG4CPLUS_HAVE_CLOCK_NANOSLEEP
+#define DCMTK_LOG4CPLUS_HAVE_FCNTL
+#define DCMTK_LOG4CPLUS_HAVE_LOCKF
+#define DCMTK_LOG4CPLUS_HAVE_FLOCK
+#define DCMTK_LOG4CPLUS_DECLSPEC_PRIVATE
+#define DCMTK_LOG4CPLUS_HAVE_TLS_SUPPORT
+#define DCMTK_LOG4CPLUS_THREAD_LOCAL_VAR
+#define DCMTK_LOG4CPLUS_HAVE___SYNC_ADD_AND_FETCH
+#define DCMTK_LOG4CPLUS_HAVE___SYNC_SUB_AND_FETCH
+#define DCMTK_LOG4CPLUS_HAVE_CXX11_ATOMICS
+#define DCMTK_LOG4CPLUS_HAVE_C99_VARIADIC_MACROS
+#define DCMTK_LOG4CPLUS_HAVE_GNU_VARIADIC_MACROS
+#define DCMTK_LOG4CPLUS_HAVE_VSNPRINTF
+#define DCMTK_LOG4CPLUS_HAVE__VSNPRINTF
+#define DCMTK_LOG4CPLUS_HAVE_VFPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE_VFWPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE_VSPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE_VSWPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE__VSNPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE__VSNWPRINTF_S
+#define DCMTK_LOG4CPLUS_HAVE_FUNCTION_MACRO
+#define DCMTK_LOG4CPLUS_HAVE_PRETTY_FUNCTION_MACRO
+#define DCMTK_LOG4CPLUS_HAVE_FUNC_SYMBOL
+#define DCMTK_LOG4CPLUS_HAVE_MBSTOWCS
+#define DCMTK_LOG4CPLUS_HAVE_WCSTOMBS
+#define DCMTK_LOG4CPLUS_HAVE_GETTID
+#define DCMTK_LOG4CPLUS_WITH_ICONV
+#define DCMTK_LOG4CPLUS_HAVE_ICONV
+#define DCMTK_LOG4CPLUS_HAVE_ICONV_CLOSE
+#define DCMTK_LOG4CPLUS_HAVE_ICONV_OPEN
Actions #4

Updated by Uli Schlachter almost 13 years ago

Log4cplus 1.1.0 does not build with MSC6 (774 errors, the first one being "cannot convert from 'void (_thiscall log4cplus::thread::SharedMutex::*)(void)' to 'void (_thiscall log4cplus::thread::SharedMutex::*)(void)'" and the other errors being equally confusing).

Ideas?

(But to be fair: It feels like half the errors are "<foo> is not in namespace std" and the other half is related to template magic in thread/syncprims.h)

Actions #5

Updated by Uli Schlachter over 12 years ago

First working patch attached.

Known issues:
- Check if the new functions in OFMap, OFVector and OFString are still needed
- Our formatEachLine property is gone
- The "P" pattern for "just the first letter of the log level" is gone

If no one objects, I will fix these and push the result.

Actions #6

Updated by Uli Schlachter over 12 years ago

No known issues left. If no one objects, I'll commit this soon (tm).

Actions #7

Updated by Uli Schlachter over 12 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

commit b2b14d78cdafcca698b5ef1c0d102386052b9fc3
Author: Uli Schlachter <>
Date: Fri Oct 26 15:54:03 2012 +0200

Update oflog to log4cplus 1.1.0
Actions #8

Updated by Jörg Riesmeier about 12 years ago

  • Tracker changed from Bug to Feature
  • Category set to Library
  • Status changed from Closed to Resolved
  • Assignee deleted (Uli Schlachter)
  • % Done changed from 100 to 60
  • Module set to oflog

Since this is a "continual process", I reopened this issue.

Actions #9

Updated by Jörg Riesmeier over 9 years ago

  • Subject changed from Abgleich mit neuester log4cplus-Version to Update "oflog" to latest log4cplus release

Current version of "log4cplus" is 1.2.0 (16 January 2016): https://sourceforge.net/p/log4cplus/news/2016/01/log4cplus-120-release/

Actions #10

Updated by Marco Eichelberg over 8 years ago

  • Target version changed from 3.6.2 to 3.6.3
Actions #11

Updated by Jan Schlamelcher over 7 years ago

  • Target version changed from 3.6.3 to 3.6.6
Actions #12

Updated by Michael Onken over 5 years ago

  • Target version deleted (3.6.6)
Actions

Also available in: Atom PDF