Actions
Feature #1220
openUse of DcmDate/Time/DateTime instead of OFDate/Time/DateTime
Status:
New
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
2026-06-05
Due date:
% Done:
0%
Estimated time:
Module:
Operating System:
Compiler:
Description
In various places in DCMTK the classes OFDate/Time/DateTime are used to retrieve the current data or time in DICOM format.
There are actually better suited methods available in the corresponding VR classes in module dcmdata (DcmDate/DcmTime/DcmDateTime):
dcmdata/libi2d/i2dplop.cc: now.getDate().getISOFormattedDate(contentDate, OFFalse); dcmdata/libi2d/i2dplop.cc: now.getTime().getISOFormattedTime(contentTime, OFFalse, OFFalse, OFFalse, OFFalse); dcmdata/libi2d/i2dplop.cc: now.getISOFormattedDateTime(acquisitionDateTime, OFFalse, OFFalse, OFFalse, OFFalse); dcmfg/libsrc/concatenationloader.cc: date.getISOFormattedDate(tempstr, OFFalse /* no delimiters */); dcmfg/libsrc/concatenationloader.cc: time.getISOFormattedTime(tempstr, OFTrue /* include seconds */, OFFalse, OFFalse, OFFalse); dcmimage/libsrc/dcmicmph.cc: (! dt.getDate().getISOFormattedDate(contentDate, OFFalse)) || dcmimage/libsrc/dcmicmph.cc: (! dt.getTime().getISOFormattedTime(contentTime, OFTrue, OFFalse, OFFalse, OFFalse))) dcmwlm/libsrc/wlmactmg.cc: dt.getISOFormattedDateTime(ts, OFTrue /* seconds */, OFTrue /* fraction */, OFFalse /* no tz */, OFFalse /* no delimiters */, "" /* no date / time separator */); dcmiod/include/dcmtk/dcmiod/iodutil.h: date.getISOFormattedDate(tempstr, OFFalse /* no delimiters */); dcmiod/include/dcmtk/dcmiod/iodutil.h: time.getISOFormattedTime(tempstr, OFTrue /* include seconds */, OFFalse, OFFalse, OFFalse);In those places where dates/times are needed in DICOM format (and not in ISO format), the code should be changed to use the VR classes.
No data to display
Actions