Project

General

Profile

Actions

Bug #1119

closed

Implement remaining corrections for OFUUID class (remove "FIXME" comments)

Added by Jörg Riesmeier almost 2 years ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Library
Target version:
Start date:
2024-04-04
Due date:
% Done:

100%

Estimated time:
Module:
ofstd
Operating System:
Compiler:

Description

The implementation of the OFUUID class still contains a few "FIXME" comments. The remaining corrections should be implemented in order to allow the use in productive environments, e.g. for generating SOP Instance UID values.


Related issues 1 (1 open0 closed)

Related to DCMTK - Feature #362: Unterstützung von "UUID as UID"New

Actions
Actions #3

Updated by Jörg Riesmeier almost 2 years ago

  • Related to Feature #362: Unterstützung von "UUID as UID" added
Actions #4

Updated by Marco Eichelberg over 1 year ago

On most operating systems, we could significantly simplify the code because a built-in UUID generation function is available:
  • Linux, MacOS, Solaris: void uuid_generate(uuid_t out);
  • Windows: RPC_STATUS UuidCreate(UUID *Uuid);
  • FreeBSD, NetBSD, OpenBSD: void uuid_create(uuid_t *uuid, uint32_t *status);

Unfortunately, Android seems to have no UUID generation function accessible from C/C++.

Actions #5

Updated by Jörg Riesmeier over 1 year ago

  • Target version changed from 3.6.9 to 3.7.2+
Actions #6

Updated by Harald Roesen 18 days ago

  • Assignee set to Harald Roesen
  • Target version changed from 3.7.2+ to 3.7.1
  • % Done changed from 0 to 100

Reimplemented OFUUID based on RFC9562.
Generation of an OFUUID is refactored into an OFUUIDGenerator.

NOTE: The "FIXME" were not addressed! The current OFUUID represents a UUID of type/variant 7. The old one was type/variant 1.
Actions #7

Updated by Harald Roesen 18 days ago

  • Status changed from New to Feedback
Actions #8

Updated by Harald Roesen 7 days ago

New implementation of OFUUID is now in place. The old OFUUID represented an UUID version 1. The current ones represent UUIDs with respect to RFC 9562, version 7. Other versions may be added by improving/enhancing OFUUIDGenerator.
The current OFUUID offers:
- monotonicity
- improved unguessability
- mitigation of security issues by not using a Media Access Control (MAC) address as version 1 does

Actions #9

Updated by Harald Roesen 7 days ago

  • Status changed from Feedback to Closed
Actions

Also available in: Atom PDF